Skip to content

[release-1.11] Change DisableDevice error to warning #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2023
Merged

[release-1.11] Change DisableDevice error to warning #1469

merged 1 commit into from
Oct 27, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #1467

/assign mattcary

The benign error when DisableDevice is not effective is logged as a warning.

@mattcary
Change DisableDevice error to warning
f09c099 
Change-Id: I3b6e586610d3f20e86b7f20bf099b6ee2451d11a
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 26, 2023
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2023
@mattcary
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2023
@mattcary
Copy link
Contributor

/retest

@mattcary
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration f09c099 link true /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mattcary
Copy link
Contributor

Integration test is failing with

    Oct 27 16:51:07.599: INFO: Driver loaded from path [/home/prow/go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/test/k8s-integration/config/test-config.yaml]: &{DriverInfo:{Name:csi-gcepd-sc-standard--no-volumesnapshotclass InTreePluginName: TestTags:[] MaxFileSize:0 SupportedSizeRange:{Max:64Ti Min:5Gi} SupportedFsType:map[:{} ext2:{} ext3:{} ext4:{} xfs:{}] SupportedMountOption:map[debug:{} noatime:{}] RequiredMountOption:map[] Capabilities:map[block:true controllerExpansion:true exec:true fsGroup:true multipods:true nodeExpansion:true offlineExpansion:true onlineExpansion:true persistence:true pvcDataSource:true topology:true] RequiredAccessModes:[] TopologyKeys:[topology.gke.io/zone] NumAllowedTopologies:1 StressTestOptions:0xc000c1de20 VolumeSnapshotStressTestOptions:<nil> PerformanceTestOptions:<nil>} StorageClass:{FromName:false FromFile:/home/prow/go/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver/test/k8s-integration/config/sc-standard.yaml FromExistingClassName:} SnapshotClass:{FromName:false FromFile: FromExistingClassName:} InlineVolumes:[] ClientNodeName: Timeouts:map[DataSourceProvision:480s]}
  Unknown Decorator
  test/e2e/storage/external/external.go:177
    [Container] node was passed an unknown decorator: '"External Storage"'

I suspect this has to do with 27afb7d75d2 <Patrick Ohly> (Mon Oct 23 17:32:06 2023 +0200) e2e storage: use framework to tag tests getting pushed to k/k, it must not work on this older branch somehow.

I'll force-merge this and we'll put sorting out the e2e tests on the queue.

@mattcary mattcary merged commit 3493076 into kubernetes-sigs:release-1.11 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiyiz leiyiz Awaiting requested review from leiyiz

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

Assignees

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k8s-infra-cherrypick-robot @mattcary @k8s-ci-robot